Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_emr_cluster: Remove instance_group configuration block, core_instance_count, core_instance_type, and master_instance_type arguments #14137

Merged
merged 1 commit into from
Jul 14, 2020
Merged

resource/aws_emr_cluster: Remove instance_group configuration block, core_instance_count, core_instance_type, and master_instance_type arguments #14137

merged 1 commit into from
Jul 14, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 10, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #13398

Release note for CHANGELOG:

* resource/aws_emr_cluster: Remove `instance_group` configuration block, `core_instance_count`, `core_instance_type`, and `master_instance_type` arguments

Already documented in the version 3 upgrade guide.

Output from acceptance testing:

--- PASS: TestAccAWSAppautoscalingScheduledAction_EMR (685.62s)

--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (795.89s)

--- PASS: TestAccAWSEMRCluster_additionalInfo (485.16s)
--- PASS: TestAccAWSEMRCluster_basic (712.73s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (1257.00s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (564.86s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (715.08s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1059.01s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (626.30s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (1044.13s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (1042.89s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (579.80s)
--- PASS: TestAccAWSEMRCluster_disappears (383.60s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (842.05s)
--- PASS: TestAccAWSEMRCluster_keepJob (510.94s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (628.70s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (881.16s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1119.47s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (951.90s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (1090.58s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (807.76s)
--- PASS: TestAccAWSEMRCluster_s3Logging (572.85s)
--- PASS: TestAccAWSEMRCluster_security_config (485.09s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (424.86s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (465.70s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (967.37s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (429.23s)
--- PASS: TestAccAWSEMRCluster_tags (835.98s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (584.57s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (1061.33s)

@bflad
resource/aws_emr_cluster: Remove instance_group configuration block…
df4693d 
…, `core_instance_count`, `core_instance_type`, and `master_instance_type` arguments

Reference: #13398

Already documented in the version 3 upgrade guide.

Output from acceptance testing:

```
--- PASS: TestAccAWSAppautoscalingScheduledAction_EMR (685.62s)

--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (795.89s)

--- PASS: TestAccAWSEMRCluster_additionalInfo (485.16s)
--- PASS: TestAccAWSEMRCluster_basic (712.73s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (1257.00s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (564.86s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (715.08s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1059.01s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (626.30s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (1044.13s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (1042.89s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (579.80s)
--- PASS: TestAccAWSEMRCluster_disappears (383.60s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (842.05s)
--- PASS: TestAccAWSEMRCluster_keepJob (510.94s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (628.70s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (881.16s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1119.47s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (951.90s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (1090.58s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (807.76s)
--- PASS: TestAccAWSEMRCluster_s3Logging (572.85s)
--- PASS: TestAccAWSEMRCluster_security_config (485.09s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (424.86s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (465.70s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (967.37s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (429.23s)
--- PASS: TestAccAWSEMRCluster_tags (835.98s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (584.57s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (1061.33s)
```
@bflad bflad added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Jul 10, 2020
@bflad bflad requested a review from a team July 10, 2020 14:42
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. service/applicationautoscaling service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jul 10, 2020
@bflad bflad added this to the v3.0.0 milestone Jul 10, 2020
@anGie44 anGie44 self-requested a review July 10, 2020 19:54
anGie44
anGie44 approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Output of acceptance tests:

--- PASS: TestAccAWSAppautoScalingTarget_multipleTargets (20.70s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_dynamo (21.17s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_Name_Duplicate (21.77s)
--- PASS: TestAccAWSAppautoScalingTarget_optionalRoleArn (21.91s)
--- PASS: TestAccAWSAppautoScalingTarget_spotFleetRequest (65.16s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_SpotFleet (66.56s)
--- PASS: TestAccAWSAppautoScalingTarget_basic (73.85s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_ECS (77.75s)
--- PASS: TestAccAWSEMRCluster_disappears (401.51s)
--- PASS: TestAccAWSEMRCluster_additionalInfo (453.23s)
--- PASS: TestAccAWSEMRCluster_Kerberos_ClusterDedicatedKdc (480.65s)
--- PASS: TestAccAWSEMRCluster_configurationsJson (502.08s)
--- PASS: TestAccAWSEMRCluster_security_config (447.11s)
--- PASS: TestAccAWSEMRCluster_Step_Basic (443.51s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_AutoscalingPolicy (555.42s)
--- PASS: TestAccAWSEMRCluster_basic (578.03s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceCount (613.00s)
--- PASS: TestAccAWSAppautoscalingScheduledAction_EMR (682.25s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceType (726.75s)
--- PASS: TestAccAWSEMRCluster_Step_Multiple (386.95s)
--- PASS: TestAccAWSEMRCluster_Ec2Attributes_DefaultManagedSecurityGroups (820.41s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_Name (857.16s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_InstanceType (870.07s)
--- PASS: TestAccAWSEMRCluster_keepJob (412.62s)
--- PASS: TestAccAWSEMRCluster_terminationProtected (441.86s)
--- PASS: TestAccAWSEMRCluster_Step_ConfigMode (922.97s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_BidPrice (1030.15s)
--- PASS: TestAccAWSEMRCluster_step_concurrency_level (438.94s)
--- PASS: TestAccAWSEMRCluster_s3Logging (580.87s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1084.64s)
--- PASS: TestAccAWSAppautoScalingTarget_emrCluster (1129.22s)
--- PASS: TestAccAWSEMRCluster_CoreInstanceGroup_BidPrice (1138.70s)
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_Name (1105.22s)
--- PASS: TestAccAWSEMRCluster_custom_ami_id (492.58s)
--- PASS: TestAccAWSEMRCluster_visibleToAllUsers (677.17s)
--- PASS: TestAccAWSEMRCluster_tags (808.28s)
--- PASS: TestAccAWSEMRCluster_root_volume_size (830.11s)
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (1316.23s)

@bflad bflad merged commit dc681c3 into master Jul 14, 2020
@bflad bflad deleted the td-aws_emr_cluster-remove-deprecated branch July 14, 2020 12:12
bflad added a commit that referenced this pull request Jul 14, 2020
@bflad
Update CHANGELOG for #14137
0f3f9b6
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/emr Issues and PRs that pertain to the emr service. size/XXL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @anGie44